New Timer App with Brand Fetching Features. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamplugged
reviewed
Sep 30, 2024
iamplugged
reviewed
Sep 30, 2024
|
@salmanfarisvp A couple of comments. Looks good otherwise. |
iamplugged
approved these changes
Sep 30, 2024
|
I found an issue with CSS on RPI screens and am working on the fix now. |
It was a chrome issue, not the code |
|
@iamplugged Changed brand logo fetching logic for svg vs jpeg/png and proxy url and plain url. I tested with different accounts and able to fetch the colour and logo and fall back logo also working as expected. |
iamplugged
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the new timer app with new brand features.